Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testbed] Remove unused AWS X-Ray mock receiver #30381

Merged

Conversation

dmitryax
Copy link
Member

The test using this mock receiver was disabled more than 3 years ago #1387 and never restored after that.

Proposing to remove the dead code to reduce the maintenance overhead.

Pinging code owner @wangzlei, @srprash. Let us know if it's ok to remove if you want to revive the test instead.

@dmitryax dmitryax requested review from a team, jpkrohling and mx-psi as code owners January 10, 2024 00:05
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command extension/healthcheck Health Check Extension testbed labels Jan 10, 2024
@dmitryax dmitryax force-pushed the testbed-remove-unused-data-receiver branch from 44ff3b1 to ef3b61d Compare January 10, 2024 00:14
@bogdandrutu
Copy link
Member

Needs a rebase

@dmitryax dmitryax force-pushed the testbed-remove-unused-data-receiver branch from ef3b61d to e2cc5c0 Compare January 11, 2024 00:05
The test using this mock receiver was disabled more than 3 years ago open-telemetry#1387 and never restored after that.

Proposing to remove the dead code to reduce the maintenance overhead.
@dmitryax dmitryax force-pushed the testbed-remove-unused-data-receiver branch from e2cc5c0 to ba98523 Compare January 11, 2024 00:57
@dmitryax dmitryax merged commit e8c85ec into open-telemetry:main Jan 11, 2024
87 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 11, 2024
@dmitryax dmitryax deleted the testbed-remove-unused-data-receiver branch January 11, 2024 21:49
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
The test using this mock receiver was disabled more than 3 years ago
open-telemetry#1387
and never restored after that.

Proposing to remove the dead code to reduce the maintenance overhead.

Pinging code owner @wangzlei, @srprash. Let us know if it's ok to remove
if you want to revive the test instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command extension/healthcheck Health Check Extension testbed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants