Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(menu): add aria-attributes and roles to menu and its components #1514

Merged
merged 2 commits into from
Jul 1, 2024
Merged

feat(menu): add aria-attributes and roles to menu and its components #1514

merged 2 commits into from
Jul 1, 2024

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented Jun 5, 2024 •
edited
Loading

Implements LIBS-622

Description

  • This feature adds relevant aria-attributes and roles to the menu and menu components, i.e. MenuDivider, MenuItem, MenuSectionHeader.

Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

@d-rita d-rita requested a review from a team as a code owner June 5, 2024 04:13
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 5, 2024 •
edited
Loading

🚀 Deployed on https://pr-1514--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify June 5, 2024 04:17 Inactive
@tomzemp tomzemp requested a review from Chisomchima June 18, 2024 10:09
@d-rita d-rita force-pushed the LIBS-622/menus-aria-attributes branch from 625b7c8 to 23baf75 Compare June 19, 2024 05:00
@dhis2-bot dhis2-bot temporarily deployed to netlify June 19, 2024 05:03 Inactive
@d-rita d-rita force-pushed the LIBS-622/menus-aria-attributes branch from 23baf75 to b5f058a Compare June 23, 2024 07:53
@dhis2-bot dhis2-bot temporarily deployed to netlify June 23, 2024 07:57 Inactive
@d-rita d-rita mentioned this pull request Jun 29, 2024
Closed
3 tasks
@kabaros kabaros merged commit 54b816c into master Jul 1, 2024
27 checks passed
@kabaros kabaros deleted the LIBS-622/menus-aria-attributes branch July 1, 2024 13:11
dhis2-bot added a commit that referenced this pull request Jul 2, 2024
@dhis2-bot
chore(release): cut 9.9.0 [skip release]
7000cf0 
# [9.9.0](v9.8.10...v9.9.0) (2024-07-02)

### Features

* **menu:** add aria-attributes and roles to menu and its components ([#1514](#1514)) ([54b816c](54b816c))
* **menu:** add keyboard accessibility to menus ([#1533](#1533)) ([235a71e](235a71e))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabaros kabaros kabaros approved these changes

@Chisomchima Chisomchima Awaiting requested review from Chisomchima

Assignees
No one assigned
Labels
accessibility released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-rita @dhis2-bot @kabaros