feat(menu): accessibility improvements to menu and menu item components #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use Up and Down arrows to move through menu items list - Use Enter and Space keys to trigger a menu item in menu
|
🚀 Deployed on https://pr-1464--dhis2-ui.netlify.app |
Passing run #3360 ↗︎
Details:
Review all test suite changes for PR #1464 ↗︎ |
|||||||||||||||
|
Closing this out for implementations broken down in PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements LIBS-556
Description
This feature improves the accessibility of the menu and menu components, i.e. MenuDivider, MenuItem, MenuSectionHeader.
UpandDownarrow keys to navigate through the list of menu items and focus them (except the menu section header and menu divider)EnterandSpacekeys to trigger actions attached to menu items (except the disabled ones). For example: opening a link, toggling a checkbox, opening a submenu, etc.Rightarrow key to open a submenu andLeftarrow key to close it.Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots
supporting text