fix: allow for nested entry-points under src #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it so that we resolve the entry-point relatively to the src folder, so src/react/index.js becomes react/index.js. This resolves an issue when the library entry-point is not defined as src/index.js. So for example src/react/index.js will fail to build because we only used the basename (index.js) to construct the build entry-point path, so the react part of the path disappears from the expected path. We got build/es/index.js when we should have gotten build/es/react/index.js. Since we force users of app-scripts to put their source code under 'src' (compiler/compile.js:15), we can safely assume that the configured entry-point can be resolved relatively to the src directory and grab everything to the right and build the path to the target directory, e.g. build/es/react/index.js.
6 tasks
Mohammer5
approved these changes
Feb 26, 2021
amcgee
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Minor change suggested, after that looks good. Thanks for fixing this @varl and for finding it @Mohammer5!
amcgee
reviewed
Feb 26, 2021
|
Thanks for the reviews. I'll merge when it passes. |
dhis2-bot
added a commit
that referenced
this pull request
Feb 26, 2021
## [5.7.2](v5.7.1...v5.7.2) (2021-02-26) ### Bug Fixes * allow for nested entry-points under src ([#519](#519)) ([3ae34b3](3ae34b3))
|
🎉 This PR is included in version 5.7.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Mar 5, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that we resolve the entry-point relatively to
the src folder, so src/react/index.js becomes react/index.js.
This resolves an issue when the library entry-point is not defined as
src/index.js.
So for example src/react/index.js will fail to build because we only
used the basename (index.js) to construct the build entry-point path, so
the react part of the path disappears from the expected path.
We got build/es/index.js when we should have gotten
build/es/react/index.js.
Since we force users of app-scripts to put their source code under
'src' (compiler/compile.js:15), we can safely assume that the configured
entry-point can be resolved relatively to the src directory and grab
everything to the right and build the path to the target directory, e.g.
build/es/react/index.js.