Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dhis2/app-platform Loading
base: v5.7.1
Choose a base ref
...
head repository: dhis2/app-platform Loading
compare: v5.7.2
Choose a head ref
  • 2 commits
  • 7 files changed
  • 2 contributors

Commits on Feb 26, 2021

  1. fix: allow for nested entry-points under src (#519) 

    This change makes it so that we resolve the entry-point relatively to
the src folder, so src/react/index.js becomes react/index.js.

This resolves an issue when the library entry-point is not defined as
src/index.js.

So for example src/react/index.js will fail to build because we only
used the basename (index.js) to construct the build entry-point path, so
the react part of the path disappears from the expected path.

We got build/es/index.js when we should have gotten
build/es/react/index.js.

Since we force users of app-scripts to put their source code under
'src' (compiler/compile.js:15), we can safely assume that the configured
entry-point can be resolved relatively to the src directory and grab
everything to the right and build the path to the target directory, e.g.
build/es/react/index.js.
    @varl
    varl committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    3ae34b3 View commit details
    Browse the repository at this point in the history

  2. chore(release): cut 5.7.2 [skip ci] 

    ## [5.7.2](v5.7.1...v5.7.2) (2021-02-26)

### Bug Fixes

* allow for nested entry-points under src ([#519](#519)) ([3ae34b3](3ae34b3))
    @dhis2-bot
    dhis2-bot committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    1aba628 View commit details
    Browse the repository at this point in the history
Loading