Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow for nested entry-points under src #519

Merged
merged 2 commits into from
Feb 26, 2021
Merged

fix: allow for nested entry-points under src #519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2101a69
fix: allow for nested entry-points under src
varl Feb 26, 2021
2dda1d9
refactor: use paths.src over hardcoded value
varl Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cli/src/lib/validators/validatePackageExports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,22 @@ module.exports.validatePackageExports = async (
const baseDir = path.dirname(paths.package)

let valid = true
const entrypointBasename = normalizeExtension(
path.basename(config.entryPoints.lib)
const relativeEntrypoint = path.relative(
paths.src,
normalizeExtension(config.entryPoints.lib)
)

const expectedESMExport =
'./' +
path.relative(
baseDir,
path.join(paths.buildOutput, 'es', entrypointBasename)
path.join(paths.buildOutput, 'es', relativeEntrypoint)
)
const expectedCJSExport =
'./' +
path.relative(
baseDir,
path.join(paths.buildOutput, 'cjs', entrypointBasename)
path.join(paths.buildOutput, 'cjs', relativeEntrypoint)
)

const expectedPackage = {
Expand Down