Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config diff #4619

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
1fc038b
story(configDiffView) : open api spec
adi6859 Feb 1, 2024
8eda368
story(configDiffView) : open api spec updated
adi6859 Feb 1, 2024
2d00c6a
story(configDiffView) : open api spec updated for error state
adi6859 Feb 1, 2024
00d1e6c
story(configDiffView) : WIP
adi6859 Feb 1, 2024
4e3582b
story(configDiffView) : WIP "some code changed"
adi6859 Feb 1, 2024
8c9a4cc
story(configDiffView) : support for names added
adi6859 Feb 2, 2024
55a2c0c
story(configDiffView) : iota removed
adi6859 Feb 2, 2024
bcdfa26
story(configDiffView) : pg no rows handled
adi6859 Feb 2, 2024
197db9b
story(configDiffView) : spelling check
adi6859 Feb 2, 2024
7469461
story(configDiffView) : code review comment resolved
adi6859 Feb 5, 2024
c7a145a
story(configDiffView) : env id added
adi6859 Feb 5, 2024
4eaa138
story(configDiffView) : intersection added
adi6859 Feb 5, 2024
256e505
story(configDiffView) : comments removed
adi6859 Feb 5, 2024
47f798f
story(configDiffView) : code review comment resolved
adi6859 Feb 6, 2024
de50f02
story(configDiffView) : comment removed
adi6859 Feb 6, 2024
f2947e3
story(configDiffView) : CMCSNames DTO moved
adi6859 Feb 6, 2024
a3b3271
story(configDiffView) : main merge
adi6859 Feb 7, 2024
44862e9
story(configDiffView) : null case handled
adi6859 Feb 7, 2024
7733ea0
story(configDiffView) : logger added
adi6859 Feb 7, 2024
06e39fc
story(configDiffView) : main merge
adi6859 Feb 8, 2024
e4e39c6
story(configDiffView) : code refactored
adi6859 Feb 8, 2024
dce967a
story(configDiffView) : code refactored v2
adi6859 Feb 8, 2024
4174161
story(configDiffView) : spec updated
adi6859 Feb 8, 2024
186efa7
story(configDiffView) : main merge
adi6859 Feb 13, 2024
736047a
story(configDiffView) : code refactored
adi6859 Feb 14, 2024
16d07d3
story(configDiffView) : config names
adi6859 Feb 14, 2024
3a55c5b
Merge branch 'main' into config-diff
prakash100198 Feb 19, 2024
a4e9c4f
Merge branch 'main' into config-diff
prakash100198 Feb 20, 2024
706afc6
merged with main
vikramdevtron Jun 25, 2024
014e59d
Merge branch 'main' into config-diff
prakash100198 Jul 3, 2024
6196f31
main sync
prakash100198 Jul 3, 2024
e076783
overridden and global flag introduced in config diff autocomplete api
prakash100198 Jul 3, 2024
a1eba0f
Merge branch 'main' into config-diff
prakash100198 Jul 9, 2024
ffa3ba1
ent sync
prakash100198 Jul 9, 2024
4749c45
Merge branch 'main' into config-diff
prakash100198 Jul 16, 2024
0e319d2
Merge branch 'main' into config-diff
prakash100198 Jul 17, 2024
2c5c7c6
using a single key instead of global and overridden key in config/aut…
prakash100198 Jul 17, 2024
8696b08
ConfigState made string instead of int
prakash100198 Jul 17, 2024
a11549f
Merge branch 'main' into config-diff
prakash100198 Jul 23, 2024
f9d9c65
not sending inheriting in case base config
prakash100198 Jul 23, 2024
359022a
Merge branch 'main' into config-diff
prakash100198 Jul 30, 2024
5628d6c
code review comment incorporation
prakash100198 Jul 30, 2024
41784ca
Merge branch 'main' into config-diff
prakash100198 Jul 31, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
story(configDiffView) : config names
  • Loading branch information
adi6859 committed Feb 14, 2024
commit 16d07d376c5a542da4467fbf0193e70a75dfc441
8 changes: 4 additions & 4 deletions internal/sql/repository/chartConfig/ConfigMapRepository.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,22 +92,22 @@ func (impl ConfigMapRepositoryImpl) GetConfigNamesForAppAndEnvLevel(appId int, e
return nil, err
}
}
var configNameAndType []bean.ConfigNameAndType
var configNames []bean.ConfigNameAndType
for _, name := range cMCSNames {
if name.CMName != "" {
configNameAndType = append(configNameAndType, bean.ConfigNameAndType{
configNames = append(configNames, bean.ConfigNameAndType{
Name: name.CMName,
Type: bean.CM,
})
}
if name.CSName != "" {
configNameAndType = append(configNameAndType, bean.ConfigNameAndType{
configNames = append(configNames, bean.ConfigNameAndType{
Name: name.CSName,
Type: bean.CS,
})
}
}
return configNameAndType, nil
return configNames, nil
}

func (impl ConfigMapRepositoryImpl) CreateAppLevel(model *ConfigMapAppModel) (*ConfigMapAppModel, error) {
Expand Down
Loading