Config diff #4619
Open
Config diff #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi6859
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
subhashish-devtron
suggested changes
Feb 2, 2024
adi6859
commented
Feb 13, 2024
adi6859
commented
Feb 13, 2024
|
|
outdated |
kartik-579
requested changes
Jul 15, 2024
| return router | ||
| } | ||
|
|
||
| func (router DeploymentConfigurationRouterImpl) initDeploymentConfigurationRouter(configRouter *mux.Router) { |
There was a problem hiding this comment.
subrouter for orchestrator/config, should add deployment in route. also service does not aligns with the name and route, have to discuss this
Comment on lines
+83
to
+84
| ColumnExpr("json_array_elements(CASE WHEN (config_map_data::json->'maps')::TEXT != 'null' THEN (config_map_data::json->'maps') ELSE '[]' END )->>'name' AS cm_name"). | ||
| ColumnExpr("json_array_elements(CASE WHEN (secret_data::json->'secrets')::TEXT != 'null' THEN (secret_data::json->'secrets') ELSE '[]' END )->>'name' AS cs_name"). |
There was a problem hiding this comment.
have to add comments here on what we are trying to achieve
pkg/configDiff/bean/bean.go
Outdated
| type ConfigState int | ||
|
|
||
| const ( | ||
| PublishedConfigState ConfigState = 3 |
There was a problem hiding this comment.
this has been removed, now we don't use enum, just simple string
| impl.logger.Errorw("error in fetching CM and CS names at app or env level", "appId", appId, "envId", envId, "err", err) | ||
| return nil, err | ||
| } | ||
| cmcsKeyPropertyAppLevelMap, cmcsKeyPropertyEnvLevelMap := helper.GetCmCsAppAndEnvLevelMap(cMCSNamesAppLevel, cMCSNamesEnvLevel) |
pkg/configDiff/helper/helper.go
Outdated
| "github.com/devtron-labs/devtron/pkg/pipeline/bean" | ||
| ) | ||
|
|
||
| func GetCmCsAppAndEnvLevelMap(cMCSNamesAppLevel, cMCSNamesEnvLevel []bean.ConfigNameAndType) (map[string]*bean2.ConfigProperty, map[string]*bean2.ConfigProperty) { |
pkg/configDiff/helper/helper.go
Outdated
| return cMCSNamesAppLevelMap, cMCSNamesEnvLevelMap | ||
| } | ||
|
|
||
| func GetConfigProperty(id int, name string, configType bean.ResourceType, State bean2.ConfigState) *bean2.ConfigProperty { |
| func (impl ConfigMapServiceImpl) FetchCmCsNamesAppAndEnvLevel(appId int, envId int) ([]bean.ConfigNameAndType, []bean.ConfigNameAndType, error) { | ||
| var cMCSNamesEnvLevel []bean.ConfigNameAndType | ||
|
|
||
| cMCSNamesAppLevel, err := impl.configMapRepository.GetConfigNamesForAppAndEnvLevel(appId, -1) |
There was a problem hiding this comment.
-1 should be used as constant to be clear what it denotes
There was a problem hiding this comment.
in ide it shows envId
# Conflicts: # api/restHandler/common/ParamParserUtils.go
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?