Don't attempt to update machines that are not running during vagrant up #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refreshing from default
fix equality comparison
austinlparker
changed the title
vagrant up
|
Thank you for the pull request @austinlparker ! This has been low hanging fruit for quite some time - beat us to it! Looks good. I'm going to run through some QA and once passed will publish a new release. |
|
Hey Seth, any word on this? |
|
Should be a day or two - stay tuned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200
Currently, when running
vagrant upaftervagrant halt(or some other combination of steps that leaves you with powered off but provisioned vagrant machines), the hostmanager plugin will attempt to update the hostsfile on each machine. However, it does this by querying the vagrant environment for created machines. This PR changes the behavior to have hostmanager only attempt to update the hosts file on running vagrant machines duringvagrant up.