Feat/extras #111
Feat/extras #111
Conversation
This depends on two patches: devopsgroup-io/vagrant-hostmanager#109 devopsgroup-io/vagrant-hostmanager#111 If they are not merged shortly, please look for them here: https://github.com/purpleidea/vagrant-hostmanager
|
@pixell and @purpleidea, both of you submitted recent PRs that in my opinion have an overlap in functionality. I'm wondering if we can implement something general enough to satisfy both use-cases. In #101, the goal is to specify specific IPs per alias, per machine. In this PR, the goal is to specify extra hosts that will be added to every machine. Since the machine-specific configs are always merged with the global config, it should be possible to implement an option that can be used at both levels. This is pretty much the functionality in this PR, except it should work at the machine level. When defined globally, it will apply to all machines. Something like this: # This applies to all machines
config.hostmanager.extra_hosts = [
{ ip: '10.0.0.2', host: 'banana', aliases: ['orange', 'strawberry'] },
{ ip: '10.0.0.3', host: 'cherry', aliases: ['raspberry', 'blueberry'] }
]
# This applies to only the one machine
config.vm.define :server1 do |machine|
## ... machine-specific config ...
machine.vm.hostmanager.extra_hosts = [
{ ip: '10.0.0.10', host: 'red', aliases: ['orange', 'yellow'] },
{ ip: '10.0.0.11', host: 'green', aliases: ['blue', 'purple'] }
]
end@purpleidea, I the main change required in your PR is to tap into the machine's config instead of the global config (ie: use What do you both think? |
This is needed on some systems so that: hostname --fqdn and facter -p | grep fqdn both return something useful. This patch adds the fqdn_friendly and domain_name configuration options.
This is necessary if you want to add a VIP to each host, or if you want to define a host that isn't part of your vagrant infrastructure, but which needs to be listed in your "DNS".
This patch adds support for adding additional
/etc/hostsentries, which aren't present in vagrant. It is necessary for VIP's, or for simply listing hosts that you want to include in your/etc/hostsfaked "DNS".This patch is based off of my earlier feature: #109
If you'd like it rebased off of master, I can do that, but it makes sense to merge the other one first, and then this one.
Cheers,
James