This plugin breaks the vagrant-libvirt hostnames

[purpleidea]

I just tried this out with vagrant-libvirt. It mostly seems to work great. The biggest issue:

When using this, it changes the host name (as seen from the vagrant-libvirt perspective) from hostname to

Example:

hosts_1406096813_626657195ee18d615f84

$ vup host1
Bringing machine 'host1' up with 'libvirt' provider...
==> host1: Creating image (snapshot of base box volume).
==> host1: Creating domain with the following settings...
==> host1:  -- Name:          hosts_1406096813_626657195ee18d615f84
==> host1:  -- Domain type:   kvm
==> host1:  -- Cpus:          1
==> host1:  -- Memory:        512M
==> host1:  -- Base box:      centos-6
==> host1:  -- Storage pool:  default
==> host1:  -- Image:         /var/lib/libvirt/images/hosts_1406096813_626657195ee18d615f84.img
==> host1:  -- Volume Cache:  default
==> host1:  -- Kernel:        
==> host1:  -- Initrd:        
==> host1:  -- Command line : 
==> host1: Starting domain.
==> host1: Waiting for domain to get an IP address...
==> host1: Waiting for SSH to become available...
==> host1: Starting domain.
==> host1: Waiting for domain to get an IP address...
==> host1: Waiting for SSH to become available...
==> host1: Creating shared folders metadata...
==> host1: Setting hostname...
==> host1: Rsyncing folder: /home/james/tmp/vagrant/hosts-hacking/ => /vagrant
==> host1: Configuring and enabling network interfaces...
==> host1: Updating /etc/hosts file on active guest machines...
==> host1: Updating /etc/hosts file on host machine (password may be required)...

I'm not entirely sure who's fault this is, if it's vagrant-libvirt or this plugin, but whatever the case, if someone can help me understand why / how this happens, and point me in the right direction, then I'll patch it.

Thanks,
James

[purpleidea]

Tracked in vagrant-libvirt as: vagrant-libvirt/vagrant-libvirt#215

[purpleidea]

Not vagrant-hostmanager's fault. I incorrectly thought it was a change this plugin did, when really it was vagrant-libvirt that changed without me realizing.

Sorry for the noise.

[pbitty]

No problem. I was just starting to look at it. Good timing. 😃

[purpleidea]

@pbitty I just wrote two patches, but I didn't hear back from the main committer... I'm guessing you're the new maintainer? If you have a chance, please have a look:
First: #109
Second: #111
(Merge in that order)

Cheers!

[pbitty]

Hi James. Thanks for contributing.
I am out of town, with no computer for the weekend. I will take a look at
the PRs early this week, k?

[purpleidea]

On Sat, Jul 26, 2014 at 9:34 AM, Paulo Bittencourt <[email protected]

wrote:

Hi James. Thanks for contributing.
I am out of town, with no computer for the weekend. I will take a look at
the PRs early this week, k?

Sounds good. I might have one subsequent change to one of those patches to
go along with a third patch coming up, but they are a good start. Cheers