forked from apache/flink
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FLINK-17266] Make WorkerResourceSpec serializable
The MesosWorkerStore requires that the WorkerResourceSpec is serializable because it stores it as part of MesosWorkerStore.Worker in serialized format. This closes apache#11821.
- Loading branch information
1 parent
3ae1da0
commit 036197e
Showing
2 changed files
with
55 additions
and
1 deletion.
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
...test/java/org/apache/flink/mesos/runtime/clusterframework/store/MesosWorkerStoreTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http:https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.flink.mesos.runtime.clusterframework.store; | ||
|
||
import org.apache.flink.runtime.resourcemanager.WorkerResourceSpec; | ||
import org.apache.flink.util.InstantiationUtil; | ||
import org.apache.flink.util.TestLogger; | ||
|
||
import org.apache.mesos.Protos; | ||
import org.junit.Test; | ||
|
||
import static org.junit.Assert.assertTrue; | ||
|
||
/** | ||
* Tests for the {@link MesosWorkerStore}. | ||
*/ | ||
public class MesosWorkerStoreTest extends TestLogger { | ||
|
||
/** | ||
* Tests that {@link MesosWorkerStore.Worker} is serializable. | ||
*/ | ||
@Test | ||
public void workerIsSerializable() { | ||
final Protos.TaskID taskId = Protos.TaskID.newBuilder().setValue("foobar").build(); | ||
final WorkerResourceSpec workerResourceSpec = new WorkerResourceSpec.Builder().build(); | ||
final Protos.SlaveID slaveId = Protos.SlaveID.newBuilder().setValue("barfoo").build(); | ||
final String hostname = "foobar"; | ||
|
||
final MesosWorkerStore.Worker worker = MesosWorkerStore.Worker.newWorker(taskId, workerResourceSpec); | ||
final MesosWorkerStore.Worker launchedWorker = worker.launchWorker(slaveId, hostname); | ||
|
||
assertTrue(InstantiationUtil.isSerializable(worker)); | ||
assertTrue(InstantiationUtil.isSerializable(launchedWorker)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters