Skip to content

Commit

Permalink
[FLINK-17266] Make WorkerResourceSpec serializable
Browse files Browse the repository at this point in the history
The MesosWorkerStore requires that the WorkerResourceSpec is serializable
because it stores it as part of MesosWorkerStore.Worker in serialized format.

This closes apache#11821.
  • Loading branch information
tillrohrmann committed Apr 21, 2020
1 parent 3ae1da0 commit 036197e
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http:https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.flink.mesos.runtime.clusterframework.store;

import org.apache.flink.runtime.resourcemanager.WorkerResourceSpec;
import org.apache.flink.util.InstantiationUtil;
import org.apache.flink.util.TestLogger;

import org.apache.mesos.Protos;
import org.junit.Test;

import static org.junit.Assert.assertTrue;

/**
* Tests for the {@link MesosWorkerStore}.
*/
public class MesosWorkerStoreTest extends TestLogger {

/**
* Tests that {@link MesosWorkerStore.Worker} is serializable.
*/
@Test
public void workerIsSerializable() {
final Protos.TaskID taskId = Protos.TaskID.newBuilder().setValue("foobar").build();
final WorkerResourceSpec workerResourceSpec = new WorkerResourceSpec.Builder().build();
final Protos.SlaveID slaveId = Protos.SlaveID.newBuilder().setValue("barfoo").build();
final String hostname = "foobar";

final MesosWorkerStore.Worker worker = MesosWorkerStore.Worker.newWorker(taskId, workerResourceSpec);
final MesosWorkerStore.Worker launchedWorker = worker.launchWorker(slaveId, hostname);

assertTrue(InstantiationUtil.isSerializable(worker));
assertTrue(InstantiationUtil.isSerializable(launchedWorker));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,15 @@
import org.apache.flink.runtime.clusterframework.TaskExecutorProcessSpec;
import org.apache.flink.util.Preconditions;

import java.io.Serializable;
import java.util.Objects;

/**
* Resource specification of a worker, mainly used by SlotManager requesting from ResourceManager.
*/
public class WorkerResourceSpec {
public final class WorkerResourceSpec implements Serializable {

private static final long serialVersionUID = 1L;

public static final WorkerResourceSpec ZERO = new Builder().build();

Expand Down

0 comments on commit 036197e

Please sign in to comment.