feat(server): plugins can create islands

[deer]

closes #1471

I'm not super excited about the implementation, but it seems to work. Perhaps we shouldn't rush this and let it go into 1.40; there would then be time to make sure it's really implemented how we want.

If anyone is really wanting this feature, they can be excited it's already up for review. 😄

[deer]

Looks like the island tests are failing on windows. Of course this works on my machine 😅 I will look into this later.

[lino-levan]

Could you add a section in the docs?

[cbinzer]

Hi, I tested the islands support and it works! Nice work!

[deer]

error: Import 'https://deno.land/[email protected]/path/glob.ts' failed: 500 Internal Server Error
at https://deno.land/[email protected]/path/mod.ts:53:15

[cbinzer]

Hi, me again :-) I am wondering how to add static files like styles or images to a plugin? Is there a way to specify this in a plugin?

[deer]

Should this be closed? The core code hasn't been changed in more than two weeks, but it didn't make it into 1.4. I guess the preferred approach is to do something different, e.g. #1602. Still a bit disappointing to have to wait at least another month until plugins can create islands.

[marvinhagemeister]

Oh looks like I misunderstood it. I wasn't sure if you wanted to see this merged since you opened #1602 and wrote this in your initial post "I'm not super excited about the implementation, but it seems to work."

I'm having the next week off and I'll take a look at this PR after that.

[deer]

It's that tough balancing act of releasing functionality that will definitely be deprecated in the future. What maintenance burden does releasing this impose, if we know we're going to do something better in the future? But on the other hand, there's a need for this now, and no concrete implementation for the "grand refactor" of projects as plugins.

Fortunately I don't have to make this decision; I can just complain! 😂

That being said, I do volunteer to fix bugs with this, just like I did with the route/middleware plugin stuff.

Edit: my point about not being super excited is that it's not going to scale to all the other things plugins might want. But it at least seems to solve this one issue.

[mcgear]

I could use this feature for sure, as i have a number of component libraries that need to register certain controls as islands... Are there plans to merge this as a temp solution while we wait for projects as plugins (#1602 )?

[deer]

Hi @marvinhagemeister, I hope you had a relaxing vacation last week. Will you be able to look at this PR this week?

Additionally it looks like a change to deno canary is causing fmt to look at the format of code within markdown files. It seems like they're not properly formatted. I'll open a PR for this.

#1715 does fix the formatting issues, but fails for some unrelated flaky test issues.

[marvinhagemeister]

Nice one! Sorry it took so long to review.