Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement expandGlob() #617

Merged
merged 20 commits into from
Oct 2, 2019
Merged

Implement expandGlob() #617

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ff97903
prettier: Refactor to use expandGlob()
nayeemrmn Sep 28, 2019
4729107
testing: Refactor to resemble prettier
nayeemrmn Sep 28, 2019
b6af0a7
Rename glob() to globToRegExp(), restructure glob related interfaces
nayeemrmn Sep 28, 2019
17adf62
Move exclude handling inside of expandGlob()
nayeemrmn Sep 29, 2019
eda4eb3
fs/walk.ts: Don't traverse directories matching a skip pattern
nayeemrmn Sep 29, 2019
a71b0a3
fs/walk.ts: Improve maxDepth handling
nayeemrmn Sep 29, 2019
f2c329a
fs/walk.ts: Add includeFiles to WalkOptions
nayeemrmn Sep 29, 2019
f071a40
fs/walk.ts: Remove walkSync()'s default root value
nayeemrmn Sep 29, 2019
0dcde6a
Add tests for proper glob expansion
nayeemrmn Sep 29, 2019
a783ffc
Implement expandGlob() and expandGlobSync()
nayeemrmn Sep 29, 2019
634b753
Review: Extract SEP_PATTERN to fs/path/constants.ts
nayeemrmn Sep 30, 2019
1f2dbd3
Review: Fix segmentation in split()
nayeemrmn Sep 30, 2019
9d46b1a
Remove strict from GlobOptions
nayeemrmn Sep 30, 2019
ceca937
Add normalizeGlob() and joinGlobs()
nayeemrmn Oct 1, 2019
8532c4e
Fix globstar parent normalization
nayeemrmn Oct 1, 2019
2d74b3b
Resolve expandGlob()'s root from CWD
nayeemrmn Oct 1, 2019
5b72711
Review: Correct docs and for loop
nayeemrmn Oct 2, 2019
b7af9a0
Review: Add a test for includeFiles for walk()
nayeemrmn Oct 2, 2019
3b1b189
fs/walk.ts: Make includeDirs true by default
nayeemrmn Oct 2, 2019
eb666fd
Implement expandGlob() and expandGlobSync()
nayeemrmn Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Implement expandGlob() and expandGlobSync() 
fs/glob.ts:
- Improve prototypes for expandGlob() and expandGlobSync() from #604.
- Rename glob() to globToRegExp().
- Add normalizeGlob() and joinGlobs().
- Extract GlobToRegExpOptions from GlobOptions, remove the strict
  and filepath options.

fs/globrex.ts:
- Add GlobrexOptions.

fs/path/constants.ts:
- Add SEP_PATTERN.

fs/walk.ts:
- Add WalkOptions::includeFiles
- Default WalkOptions::includeDirs to true.
- Don't traverse directories matching a skip pattern.
- Remove walkSync()'s default root value.

prettier:
- Refactor to use expandGlob().

testing:
- Make findTestModules() an async generator.
  • Loading branch information
@nayeemrmn
nayeemrmn committed Oct 2, 2019
commit eb666fdef230ac885105ef4f62dcbdabe1a1fbaa

No changes to show.

This commit has no content.