Implement expandGlob() #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
force-pushed
the
expand-glob
branch
from
146b76a
to
f4cc885
Compare
Regression. The prettier tests will fail until expandGlob() is fixed since they try to match absolute paths outside of CWD.
Should help later when extracting common functionality to expandGlob(), like exclusion. Makes findTestModules() an async generator.
nayeemrmn
force-pushed
the
expand-glob
branch
from
f4cc885
to
4729107
Compare
nayeemrmn
force-pushed
the
expand-glob
branch
from
a2e441f
to
b6af0a7
Compare
Adds an exclude field to ExpandGlopOptions. This should be the final API.
nayeemrmn
force-pushed
the
expand-glob
branch
from
f1d05be
to
de35f8f
Compare
In other words, support path prefixes when specifying excludes. This aligns with the file matchers of the test runner and prettier. It's less redundant since this cannot be achieved efficiently on the client-end.
nayeemrmn
force-pushed
the
expand-glob
branch
from
de35f8f
to
eda4eb3
Compare
nayeemrmn
force-pushed
the
expand-glob
branch
5 times, most recently
from
437e930
to
9b1b634
Compare
nayeemrmn
force-pushed
the
expand-glob
branch
from
9b1b634
to
a783ffc
Compare
|
@ry @bartlomieju Ready for review! I've checked that |
zekth
reviewed
Sep 29, 2019
|
@kt3k a review from you would be appreciated if you have the time. |
kt3k
reviewed
Sep 30, 2019
kt3k
reviewed
Sep 30, 2019
kt3k
reviewed
Sep 30, 2019
kt3k
reviewed
Sep 30, 2019
|
@nayeemrmn In your description, it says "DON'T MERGE". Please update if it is no longer applicable. |
kt3k
reviewed
Oct 1, 2019
|
@ry Fixed! Ready again. |
|
//fs/README has |
kt3k
reviewed
Oct 2, 2019
kt3k
reviewed
Oct 2, 2019
kt3k
reviewed
Oct 2, 2019
ry
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
LGTM - nice PR @nayeemrmn!
(And thanks for the careful review @kt3k )
|
@nayeemrmn Can you draft a commit message so I can squash this all up? |
fs/glob.ts: - Improve prototypes for expandGlob() and expandGlobSync() from denoland#604. - Rename glob() to globToRegExp(). - Add normalizeGlob() and joinGlobs(). - Extract GlobToRegExpOptions from GlobOptions, remove the strict and filepath options. fs/globrex.ts: - Add GlobrexOptions. fs/path/constants.ts: - Add SEP_PATTERN. fs/walk.ts: - Add WalkOptions::includeFiles - Default WalkOptions::includeDirs to true. - Don't traverse directories matching a skip pattern. - Remove walkSync()'s default root value. prettier: - Refactor to use expandGlob(). testing: - Make findTestModules() an async generator.
|
@ry Added an empty commit with the message. |
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
fs/glob.ts: - Improve prototypes for expandGlob() and expandGlobSync() from denoland/deno_std#604. - Rename glob() to globToRegExp(). - Add normalizeGlob() and joinGlobs(). - Extract GlobToRegExpOptions from GlobOptions, remove the strict and filepath options. fs/globrex.ts: - Add GlobrexOptions. fs/path/constants.ts: - Add SEP_PATTERN. fs/walk.ts: - Add WalkOptions::includeFiles - Default WalkOptions::includeDirs to true. - Don't traverse directories matching a skip pattern. - Remove walkSync()'s default root value. prettier: - Refactor to use expandGlob(). testing: - Make findTestModules() an async generator. Original: denoland/deno_std@8c90bd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...properly. Fixes #576.
This had to be done from scratch unless we could utilise
globrexsomehow but I think it can be done by splitting paths and flat-mapping on each segment, applyingglobrexon individual segments. I also want to give it anexcludeoption so excluded directories won't be traversed - callers all want to exclude by path prefix anyway, this is currently done with a hackygflag.