print out the failed tests after the summary #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oygen87
changed the title
bartlomieju
approved these changes
Aug 9, 2019
use existing model that didnt get populated with test results. only initialized to default values. Show error message underneith aswell, but added option so we can turn it off. but usually we want to know what the error is and not only the name(just like when we run the tests and print out the error, now we see them at the bottom summary too)
oygen87
changed the title
zekth
reviewed
Aug 9, 2019
bartlomieju
reviewed
Aug 9, 2019
|
Cool - looks good. I will wait for #556 before landing this one. |
|
@bartlomieju PTAL |
bartlomieju
approved these changes
Aug 22, 2019
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 575 tests and it is a problem to scroll up the terminal to see which tests failed.
So I added a summary of all the failed tests down under with a red label next to them.
These changes will only affect cases when we have failed tests (If all tests pass, it will look like before.)
Also some refactoring to use existing
TestResultmodel and populate it with the test results. We only initialized it before when going Serial testing and could not extract the details from each test afterwards.proposed look :
