Skip to content

Commit

Permalink
print out the failed tests after the summary (denoland/std#554)
Browse files Browse the repository at this point in the history
  • Loading branch information
oygen87 authored and ry committed Aug 22, 2019
1 parent 77a20ec commit e933a8a
Showing 1 changed file with 33 additions and 2 deletions.
35 changes: 33 additions & 2 deletions testing/mod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export function test(

const RED_FAILED = red("FAILED");
const GREEN_OK = green("OK");
const RED_BG_FAIL = bgRed(" FAIL ");

interface TestStats {
filtered: number;
Expand Down Expand Up @@ -201,6 +202,17 @@ function report(result: TestResult): void {
result.printed = true;
}

function printFailedSummary(results: TestResults): void {
results.cases.forEach(
(v): void => {
if (!v.ok) {
console.error(`${RED_BG_FAIL} ${red(v.name)}`);
console.error(v.error);
}
}
);
}

function printResults(
stats: TestStats,
results: TestResults,
Expand All @@ -220,7 +232,7 @@ function printResults(
}
// Attempting to match the output of Rust's test runner.
print(
`\ntest result: ${stats.failed ? RED_FAILED : GREEN_OK}. ` +
`\ntest result: ${stats.failed ? RED_BG_FAIL : GREEN_OK} ` +
`${stats.passed} passed; ${stats.failed} failed; ` +
`${stats.ignored} ignored; ${stats.measured} measured; ` +
`${stats.filtered} filtered out ` +
Expand Down Expand Up @@ -287,6 +299,7 @@ async function runTestsParallel(

async function runTestsSerial(
stats: TestStats,
results: TestResults,
tests: TestDefinition[],
exitOnFail: boolean,
disableLog: boolean
Expand All @@ -309,13 +322,30 @@ async function runTestsSerial(
print(
GREEN_OK + " " + name + " " + promptTestTime(end - start, true)
);
results.cases.forEach(
(v): void => {
if (v.name === name) {
v.ok = true;
v.printed = true;
}
}
);
} catch (err) {
if (disableLog) {
print(CLEAR_LINE, false);
}
print(`${RED_FAILED} ${name}`);
print(err.stack);
stats.failed++;
results.cases.forEach(
(v): void => {
if (v.name === name) {
v.error = err;
v.ok = false;
v.printed = true;
}
}
);
if (exitOnFail) {
break;
}
Expand Down Expand Up @@ -367,7 +397,7 @@ export async function runTests({
if (parallel) {
await runTestsParallel(stats, results, tests, exitOnFail);
} else {
await runTestsSerial(stats, tests, exitOnFail, disableLog);
await runTestsSerial(stats, results, tests, exitOnFail, disableLog);
}
const end = performance.now();
if (disableLog) {
Expand All @@ -379,6 +409,7 @@ export async function runTests({
// promise rejections being swallowed.
setTimeout((): void => {
console.error(`There were ${stats.failed} test failures.`);
printFailedSummary(results);
Deno.exit(1);
}, 0);
}
Expand Down

0 comments on commit e933a8a

Please sign in to comment.