Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: bench async op baseline #9954

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Apr 1, 2021

This extends the op_baseline bench introduced in #9924 to also bench async ops.

Here's a comparison of main vs #9947:

Before:
test bench_op_async   ... bench:   1,256,422 ns/iter (+/- 27,839)
test bench_op_nop     ... bench:     323,275 ns/iter (+/- 7,916)
test bench_op_pi_bin  ... bench:     810,688 ns/iter (+/- 26,193)
test bench_op_pi_json ... bench:     703,911 ns/iter (+/- 44,627)

After:
test bench_op_async   ... bench:     805,011 ns/iter (+/- 22,248)
test bench_op_nop     ... bench:     318,809 ns/iter (+/- 11,228)
test bench_op_pi_bin  ... bench:     408,557 ns/iter (+/- 21,002)
test bench_op_pi_json ... bench:     315,826 ns/iter (+/- 23,131)

@AaronO AaronO changed the title perf: bench op_baseline for async ops perf: bench async op baseline Apr 1, 2021
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit ee3aa61 into denoland:main Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants