core: js errors as unions vs tuples to reduce allocs #9947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an op-layer optimization follow-up to #9843.
It shaves off
~350ns/op
of baseline overhead, making them over 2x faster by reducing allocs.Instead of returning JS results as tuples of
(Option<T>, Option<Err>)
it returns them as a conceptual union type, avoiding allocating the wrapping array. We then use a "special" key name to recognize errors.So far I've picked the error-key to be
$err_class_name
, but this can be easily changed or adjusted.Results
Op-baseline benches: