clippy

serde_v8/examples/basic.rs

@@ -1,5 +1,4 @@
 use rusty_v8 as v8;
-use serde_v8;
 
 use serde::Deserialize;
 

serde_v8/src/de.rs

@@ -268,8 +268,8 @@ impl<'de, 'a, 'b, 's, 'x> de::Deserializer<'de>
  // Regular struct
  let obj = v8::Local::<v8::Object>::try_from(self.input).unwrap();
  let map = ObjectAccess {
- fields: fields,
- obj: obj,
+ fields,
+ obj,
  pos: 0,
  scope: self.scope,
  _cache: None,
@@ -387,7 +387,6 @@ fn v8_struct_key<'s>(
  v8::NewStringType::Internalized,
  )
  .unwrap()
- .into()
 
  // TODO: consider external strings later
  // right now non-deduped external strings (without KeyCache)

serde_v8/src/error.rs

@@ -1,4 +1,3 @@
-use std;
 use std::fmt::{self, Display};
 
 use serde::{de, ser};

serde_v8/src/magic.rs

@@ -1,11 +1,10 @@
 use rusty_v8 as v8;
-use serde;
 
 use std::fmt;
 use std::marker::PhantomData;
 
-pub const FIELD: &'static str = "$__v8_magic_value";
-pub const NAME: &'static str = "$__v8_magic_Value";
+pub const FIELD: &str = "$__v8_magic_value";
+pub const NAME: &str = "$__v8_magic_Value";
 
 pub struct Value<'s> {
  pub v8_value: v8::Local<'s, v8::Value>,

serde_v8/src/ser.rs

@@ -13,10 +13,7 @@ type JsResult<'s> = Result<JsValue<'s>>;
 
 type ScopePtr<'a, 'b> = Rc<RefCell<v8::EscapableHandleScope<'a, 'b>>>;
 
-pub fn to_v8<'a, 'b, T>(
- scope: &mut v8::HandleScope<'a>,
- input: T,
-) -> JsResult<'a>
+pub fn to_v8<'a, T>(scope: &mut v8::HandleScope<'a>, input: T) -> JsResult<'a>
 where
  T: Serialize,
 {
@@ -604,5 +601,4 @@ fn v8_struct_key<'s>(
  v8::NewStringType::Internalized,
  )
  .unwrap()
- .into()
 }

serde_v8/tests/de.rs

@@ -1,5 +1,4 @@
 use rusty_v8 as v8;
-use serde_v8;
 
 use serde::Deserialize;
 
@@ -52,7 +51,7 @@ fn de_basic() {
 
  let v: v8::Local<v8::Value> = v8::Number::new(scope, 12345.0).into();
  let x: f64 = serde_v8::from_v8(scope, v).unwrap();
- assert_eq!(x, 12345.0);
+ assert!((x - 12345.0).abs() < f64::EPSILON);
  }
 
  v8_shutdown();

serde_v8/tests/magic.rs

@@ -1,5 +1,4 @@
 use rusty_v8 as v8;
-use serde_v8;
 
 use serde::{Deserialize, Serialize};