Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: introduce serde_v8 #9722

Merged
merged 24 commits into from
Mar 26, 2021
Merged

core: introduce serde_v8 #9722

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
271d061
core: introduce serde_v8
AaronO Mar 8, 2021
9953b72
tweaks
AaronO Mar 10, 2021
32b5674
Add trimmed serde_v8 to tree
AaronO Mar 18, 2021
9fc710b
fmt
AaronO Mar 18, 2021
a2f6206
clippy
AaronO Mar 18, 2021
057e915
fmt serde_v8/README.md
AaronO Mar 18, 2021
751a83d
serde_v8: flesh out README
AaronO Mar 24, 2021
886884d
serde_v8: implement serialize_map
AaronO Mar 24, 2021
f37a87b
serde_v8: remove pointless tests/lib.rs
AaronO Mar 24, 2021
36c59dc
serde_v8: modularize and extend tests/de
AaronO Mar 24, 2021
1a1ac2a
serde_v8: test de_map
AaronO Mar 24, 2021
084b22b
serde_v8: support deserializing undefined to unit type
AaronO Mar 24, 2021
3a05f88
serde_v8: add tests/ser
AaronO Mar 24, 2021
27c24e0
serde_v8: drop isolate use for BTreeMap, use full path
AaronO Mar 24, 2021
8ef301c
serde_v8: implement deserialize_map
AaronO Mar 24, 2021
8ee0fe2
serde_v8: add json compatibility tests for de
AaronO Mar 24, 2021
4948051
serde_v8: implement deserialize_str
AaronO Mar 24, 2021
c6d9159
clippy
AaronO Mar 24, 2021
02f12f2
serde_v8: add json compatibility tests for ser
AaronO Mar 24, 2021
30bdbcb
serde_v8/tests: simplify objEqual utility func
AaronO Mar 25, 2021
cbbb7a7
serde_v8/tests: further simplify obj/array equality funcs
AaronO Mar 25, 2021
22ecb86
serde_v8: improve error messages
AaronO Mar 26, 2021
a26f5ea
serde_v8: add comments explaining passthrough value
AaronO Mar 26, 2021
90709c3
serde_v8: move common key code to keys.rs
AaronO Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweaks
  • Loading branch information
@AaronO
AaronO committed Mar 19, 2021
commit 9953b72586e7aa2b49bc62eaa06e3a3b61325c20
7 changes: 3 additions & 4 deletions core/bindings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ use std::option::Option;
use url::Url;
use v8::MapFnTo;

use serde::{Serialize};
use serde_v8::{from_v8, to_v8};
use serde::Serialize;
use serde_v8::to_v8;

lazy_static! {
pub static ref EXTERNAL_REFERENCES: v8::ExternalReferences =
Expand Down Expand Up @@ -482,7 +482,7 @@ fn eval_context(
thrown: serde_v8::Value<'s>,
is_native_error: bool,
is_compile_error: bool,
};
}

let tc_scope = &mut v8::TryCatch::new(scope);
let name = v8::String::new(
Expand Down Expand Up @@ -781,7 +781,6 @@ fn get_promise_details(
args: v8::FunctionCallbackArguments,
mut rv: v8::ReturnValue,
) {

let promise = match v8::Local::<v8::Promise>::try_from(args.get(0)) {
Ok(val) => val,
Err(_) => {
Expand Down