fix(core) assertion failure in case of js error #9721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@inteon could you provide a test for this edge case? |
|
@bartlomieju done |
bartlomieju
approved these changes
Mar 8, 2021
| @@ -2024,6 +2027,49 @@ pub mod tests { | |||
| }); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn shared_queue_not_empty_when_js_error() { | |||
There was a problem hiding this comment.
I've verified that this test fails on main:
---- runtime::tests::shared_queue_not_empty_when_js_error stdout ----
thread 'runtime::tests::shared_queue_not_empty_when_js_error' panicked at 'assertion failed: `(left == right)`
left: `1`,
right: `0`', core/runtime.rs:1438:7
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted this bugfix from #9457.
In case JavaScript throws an unhandled error, part of the "shared_queue" could be still unprocessed. If this is the case; throw the js runtime error instead of asserting on the queue size not being 0.