refactor(deno/core): Move buffer_ops to deno core & merge logic with json_ops #9457
Conversation
|
Used by #9323. |
There was a problem hiding this comment.
@inteon there a lot going on in this PR. In general I think these changes are desirable, but to be honest it's quite hard to approve this PR with confidence as it touches as lot of critical infrastructure. Could you maybe split it into two smaller PRs? First which reorganizes file by moving existing implementation of "minimal ops" to "core/", and second which unifies implementation between "json" and "buffer" ops.
|
@bartlomieju I'll see what I can do. I plan to work on this tomorrow. |
inteon
changed the title
There was a problem hiding this comment.
@inteon looks great, could you rewrite core/examples/http_bench_bin_ops.rs to use this new dispatch?
There was a problem hiding this comment.
LGTM, thanks you @inteon, very nice cleanup. As with previous PRs I will be monitoring benchmarks after landing and if there's a noticeable impact I will revert to look for bottlenecks
This PR is an effort to allow for more general js <-> rs message passing. It fixes #8173, by moving minimal ops to deno core.
This new system can be used to efficiently send and receive array-buffer messages (like minimal ops), but allso allows to return messages of arbitrary length (can be used for worker communication).