-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Deno.core.heapStats() #9659
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
65dcbc0
Implement Deno.core.heapStats()
AaronO d2dd655
fmt
AaronO 5e9c409
fmt
AaronO 9f2c4ee
Add integration test for heapstats
AaronO c8dbeef
core: use camelCase for heapstats' keys
AaronO b9aeea6
cli/tests: update heapstats test to use camelCase keys
AaronO 56a9232
reset CI
bartlomieju 2e90f37
Merge branch 'main' into core/heap-stats
bartlomieju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you're wrapping
v8::HeapStatistics
because that makes it easier to serialize in the future?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, with
serde_v8
(and the new op-ABI) all theset_prop()
calls would become a one-linerto_v8()
and by keeping it in a struct we can have serde handle the camelCase-ification (if desired).There are other core binding funcs that will be simplified with
serde_v8
, e.g:get_proxy_details
andget_promise_details
conceptually return tuples, whichserde_v8
can serialize to JS arrays (removing a fair amount of boilerplate in each function)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could probably add some simple alloc-dealloc tests (of large arrays) to ensure they are correctly reflected in the metrics.
Anything else that warrants testing in your opinion ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaronO such test would be sufficient