Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Deno.core.heapStats() #9659

Merged
merged 8 commits into from
Mar 23, 2021
Merged

feat(core): Deno.core.heapStats() #9659

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
65dcbc0
Implement Deno.core.heapStats()
AaronO Mar 3, 2021
d2dd655
fmt
AaronO Mar 3, 2021
5e9c409
fmt
AaronO Mar 3, 2021
9f2c4ee
Add integration test for heapstats
AaronO Mar 15, 2021
c8dbeef
core: use camelCase for heapstats' keys
AaronO Mar 15, 2021
b9aeea6
cli/tests: update heapstats test to use camelCase keys
AaronO Mar 15, 2021
56a9232
reset CI
bartlomieju Mar 16, 2021
2e90f37
Merge branch 'main' into core/heap-stats
bartlomieju Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
@AaronO
AaronO committed Mar 3, 2021
commit d2dd655ddd4050686f6336285e8fa0634f40f1dd
43 changes: 34 additions & 9 deletions core/bindings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,25 +940,50 @@ fn heap_stats(
let val = v8::Number::new(scope, value as f64);
obj.set(scope, key.into(), val.into());
}
let s = get_heap_stats(scope);

let s = get_heap_stats(scope);

// TODO: use serde for this once we have serde_v8
let obj = v8::Object::new(scope);
set_prop(scope, obj, "total_heap_size", s.total_heap_size);
set_prop(scope, obj, "total_heap_size_executable", s.total_heap_size_executable);
set_prop(
scope,
obj,
"total_heap_size_executable",
s.total_heap_size_executable,
);
set_prop(scope, obj, "total_physical_size", s.total_physical_size);
set_prop(scope, obj, "total_available_size", s.total_available_size);
set_prop(scope, obj, "total_global_handles_size", s.total_global_handles_size);
set_prop(scope, obj, "used_global_handles_size", s.used_global_handles_size);
set_prop(
scope,
obj,
"total_global_handles_size",
s.total_global_handles_size,
);
set_prop(
scope,
obj,
"used_global_handles_size",
s.used_global_handles_size,
);
set_prop(scope, obj, "used_heap_size", s.used_heap_size);
set_prop(scope, obj, "heap_size_limit", s.heap_size_limit);
set_prop(scope, obj, "malloced_memory", s.malloced_memory);
set_prop(scope, obj, "external_memory", s.external_memory);
set_prop(scope, obj, "peak_malloced_memory", s.peak_malloced_memory);
set_prop(scope, obj, "number_of_native_contexts", s.number_of_native_contexts);
set_prop(scope, obj, "number_of_detached_contexts", s.number_of_detached_contexts);

set_prop(
scope,
obj,
"number_of_native_contexts",
s.number_of_native_contexts,
);
set_prop(
scope,
obj,
"number_of_detached_contexts",
s.number_of_detached_contexts,
);

rv.set(obj.into());
}

Expand All @@ -981,7 +1006,7 @@ struct HeapStats {
fn get_heap_stats(isolate: &mut v8::Isolate) -> HeapStats {
let mut s = v8::HeapStatistics::default();
isolate.get_heap_statistics(&mut s);

HeapStats {
total_heap_size: s.total_heap_size(),
total_heap_size_executable: s.total_heap_size_executable(),
Expand Down