feat(runtime/permissions): prompt fallback #9376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
force-pushed
the
permission_prompt_fallback
branch
from
4b4c06f
to
0849cdc
Compare
# Conflicts: # runtime/ops/timers.rs
# Conflicts: # runtime/ops/os.rs # runtime/ops/process.rs # runtime/ops/worker_host.rs
# Conflicts: # runtime/permissions.rs
nayeemrmn
reviewed
Mar 30, 2021
# Conflicts: # runtime/permissions.rs
# Conflicts: # op_crates/websocket/lib.rs # runtime/ops/fs.rs # runtime/ops/net.rs # runtime/ops/os.rs # runtime/ops/process.rs
kt3k
reviewed
Apr 10, 2021
|
As far as I tested with 56a7ee6 this looks good to me 👍 It might be better to add unit test of prompt-enabled permissions using |
# Conflicts: # op_crates/fetch/lib.rs
bartlomieju
approved these changes
Apr 11, 2021
# Conflicts: # .github/workflows/ci.yml
|
Thank you, Crowl. Nice feature to have! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
--promptflag that changes behavior of permissionchecking to displaying interactive prompt instead of failing on missing
permissions.
Based on #9367
Closes #3811