Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: touch diff from main #10132

Closed
wants to merge 2 commits into from
Closed

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Apr 11, 2021

The current CI cache has problem with detection of newer source files. If build cache is created after any of branch's commit, cargo failed to detect newer source files, and it causes false negative rebuilding.

To avoid above problem, this workaround touches all files changed from main (git diff --name-only origin/main HEAD).

I tested this script in #9376, which once caused the above problem in https://github.com/denoland/deno/runs/2314683208, but fixed with this script in https://github.com/denoland/deno/runs/2316199508 (the build time of windows job took reasonable amount of time, 20 min, about a half of full build.

(alternative approach to #10110)

@kt3k
Copy link
Member Author

kt3k commented Apr 11, 2021

closing in favor of #10110. I believe this has the same effect with #10110

@kt3k kt3k closed this Apr 11, 2021
@kt3k kt3k deleted the ci/touch-diff-from-main branch March 1, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant