Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix benchmark publish #7232

Merged
merged 1 commit into from
Aug 28, 2020
Merged

fix benchmark publish #7232

merged 1 commit into from
Aug 28, 2020

Conversation

ry
Copy link
Member

@ry ry commented Aug 28, 2020 •
edited
Loading

ref #7134

@ry ry requested a review from bartlomieju August 28, 2020 15:12
piscisaureus
piscisaureus approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

D:\deno>grep "from benchmark" -r tools
tools/build_benchmark_jsons.py:from benchmark import read_json, write_json

Looks like that was all :)

@ry ry merged commit 2573d09 into denoland:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ry @piscisaureus @bartlomieju