refactor(benchmark) Move benchmarks to Rust #7134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All benchmarks are done in Rust and can be invoked with `cargo bench`. Currently this has it's own "harness" that behaves like `./tools/benchmark.py` did. Because of this tests inside `cli/bench` are currently not run. This should be switched to the language provided harness once the `#[bench]` attribute has been stabilized.
|
@SyrupThinker great PR! Could you please rebase to include latest benchmark for
Could you put those utils in |
piscisaureus
approved these changes
Aug 27, 2020
ry
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
@SyrupThinker Thank you for this work! Nicely done.
I'm a bit worried this is going to break something - but let's land it and closely monitor the benchmarks.
LGTM
Merged
|
After landing it looks like this has made significant changes to the benchmarks...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All benchmarks are done in Rust and can be invoked with
cargo bench.Currently this has it's own "harness" that behaves like
./tools/benchmark.pydid.Because of this tests inside
cli/benchare currently not run.This should be switched to the language provided harness
once the
#[bench]attribute has been stabilized.