Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove default --allow-read perm for deno test #5208

Merged
merged 2 commits into from
May 10, 2020
Merged

fix: remove default --allow-read perm for deno test #5208

merged 2 commits into from
May 10, 2020

Conversation

bartlomieju
Copy link
Member

Not sure why but during test_parse allow_read permission was always granted.

This PR removes it.

@bartlomieju bartlomieju requested a review from ry May 10, 2020 13:14
@bartlomieju bartlomieju mentioned this pull request May 10, 2020
Merged
ry
ry approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 0d148c6 into denoland:master May 10, 2020
@bartlomieju bartlomieju deleted the fix_deno_test_perms branch May 10, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @ry