refactor: check permissions in SourceFileFetcher #5011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
force-pushed
the
file_fetcher_permissions
branch
from
79d9454
to
ad9ad41
Compare
bartlomieju
changed the title
bartlomieju
commented
May 10, 2020
|
|
bartlomieju
force-pushed
the
file_fetcher_permissions
branch
from
ba88105
to
dd00b6a
Compare
|
Note to self: update workers and runtime compiler API docs with note that read/net permission are now required |
bartlomieju
force-pushed
the
file_fetcher_permissions
branch
from
7fc6e29
to
f576f8d
Compare
ry
reviewed
May 11, 2020
ry
reviewed
May 11, 2020
ry
reviewed
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hot-fixes permission escapes in dynamic imports, workers
and runtime compiler APIs.
permissionsparameter was added to public APIs ofSourceFileFetcherand appropriate permission checks are performed during loading of
local and remote files.
Fixes #4781
Fixes #4744