Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FileWrite #5

Closed
wants to merge 1 commit into from
Closed

Implement FileWrite #5

wants to merge 1 commit into from

Conversation

qti3e
Copy link
Contributor

@qti3e qti3e commented May 29, 2018

No description provided.

YurySolovyov
YurySolovyov reviewed May 29, 2018
View reviewed changes
util.ts Outdated
export function strToUint8Array(str: string): Uint8Array {
const ab = new ArrayBuffer(str.length);
const ta = new Uint8Array(ab);
ta.forEach((_, i) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use .map ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YurySolovyov thank you : )

@styfle
Copy link
Contributor

styfle commented Jun 1, 2018

I'm curious, why this is named fileWrite instead of writeFile?

@qti3e
Copy link
Contributor Author

qti3e commented Jun 1, 2018

@styfle because it's going to have the same behaviour of good old write function, so we should call it write but then the name would be confusing so we should say it's write function from file family. (a group of functions).
So simply File.Write -> FileWrite : )
man 2 write

@styfle
Copy link
Contributor

styfle commented Jun 1, 2018

Go lang uses ioutil.WriteFile and Node.js uses fs.writeFile so I was expecting writeFile but I guess FileWrite is fine too 😅

@kevinkassimo
Copy link
Contributor

Need to update sendMsg to pubInternal, see #136

@gillchristian gillchristian mentioned this pull request Jun 10, 2018
Closed
@ry
Copy link
Member

ry commented Jun 22, 2018

@qti3e we will revisit rust soon. Closing this now.

@ry ry closed this Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YurySolovyov YurySolovyov YurySolovyov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qti3e @styfle @kevinkassimo @ry @YurySolovyov