Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] rename sendMsg to pubInternal and refactor some import statements #136

Merged
merged 1 commit into from
Jun 5, 2018
Merged

[fix] rename sendMsg to pubInternal and refactor some import statements #136

merged 1 commit into from
Jun 5, 2018

Conversation

monkingxue
Copy link
Contributor

ATT

Checklist

  • make test passes
  • tests and/or benchmarks are included
  • documentation is changed or added

ry
ry approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks - I think this improves naming

@ry ry merged commit 78124cd into denoland:master Jun 5, 2018
@kevinkassimo kevinkassimo mentioned this pull request Jun 7, 2018
Closed
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Oct 7, 2019
@43081j @ry
log: add tests (denoland#136)
4b054d6
humancalico pushed a commit to humancalico/deno that referenced this pull request Aug 24, 2020
@bartlomieju
Make syntax configurable (denoland#136)
3bc6e5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@monkingxue @ry