Remove core/plugin.rs #4824
Merged
Remove core/plugin.rs #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes unnecessary RwLock and Rc around the op registry table - Preparation to move resource_table to deno_core::Isolate. - Towards denoland#3453, denoland#4222
bartlomieju
reviewed
Apr 20, 2020
Comment on lines
-95
to
-97
| let op_id = isolate | ||
| .register_op(&format!("plugin_{}_{}", rid, op.0), state.core_op(op.1)); | ||
| plugin_resource.ops.insert(op.0, op_id); |
There was a problem hiding this comment.
This bit was used to make sure there are no ops with duplicate name - right now program will panic if you try to open a plugin that registers op with already existing name
There was a problem hiding this comment.
That's right. The plugin interface is far from stable - for now I'm opting for simplicity over safety and completeness. Once op crates are working, we can consider how to provide a better developer experience.
bartlomieju
approved these changes
Apr 20, 2020
SASUKE40
pushed a commit
to SASUKE40/deno
that referenced
this pull request
May 7, 2020
This simplifies the plugin interface in order to deliver op crates with a similar API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4821
This simplifies the plugin interface in order to deliver op crates with a similar API.