Modify op dispatcher to include &mut Isolate argument #4821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
- Removes unnecessary RwLock and Rc around the op registry table - Preparation to move resource_table to deno_core::Isolate. - Towards denoland#3453, denoland#4222
bartlomieju
approved these changes
Apr 19, 2020
|
|
||
| #[derive(Default)] | ||
| pub struct OpRegistry { | ||
| dispatchers: RwLock<Vec<Rc<OpDispatcher>>>, | ||
| name_to_id: RwLock<HashMap<String, OpId>>, | ||
| dispatchers: Vec<Rc<OpDispatcher>>, |
| let mut registry = Self::default(); | ||
| let op_id = registry.register("ops", |isolate, _, _| { | ||
| let buf = isolate.op_registry.json_map(); | ||
| Op::Sync(buf) |
SASUKE40
pushed a commit
to SASUKE40/deno
that referenced
this pull request
May 7, 2020
- Removes unnecessary RwLock and Rc around the op registry table - Preparation to move resource_table to deno_core::Isolate. - Towards denoland#3453, denoland#4222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3453, #4222