Add close method to Plugin (#4670) #4785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went for a "good first issue": #4670
Added a
close()
method toPlugin
.Looked at
File.close
and added the same implementation: Adds areadonly rid
, and runsclose
fromops/resources.ts
, returningvoid
.I don't think there is testing of plugins set up in
cli/js/tests
, but a few simple tests intest_plugin
which can be checked bycargo test
.In
test_plugin/test.js
I record the open resources at the beginning of the file, and check for equality after runningPlugin.close()
in the end.This is a simple adaptation of
assertResources()
incli/js/testing.js
, which would probably be preferable if plugin tests were added tocli/js/tests
.