Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin should be able to close #4670

Closed
manyuanrong opened this issue Apr 8, 2020 · 0 comments
Closed

plugin should be able to close #4670

manyuanrong opened this issue Apr 8, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@manyuanrong
Copy link
Contributor

Currently openPlugin will create a resource and add it to resourse_table. But now it cannot be closed, resulting in the failure of the test case

Error: Test case is leaking resources.
Before: {
  "0": "stdin",
  "1": "stdout",
  "2": "stderr"
}
After: {
  "0": "stdin",
  "1": "stdout",
  "2": "stderr",
  "6": "plugin"
}
    at Object.assert ($deno$/util.ts:25:11)
    at resourceSanitizer ($deno$/testing.ts:62:5)
    at async TestApi.[Symbol.asyncIterator] ($deno$/testing.ts:222:11)
    at async runTests ($deno$/testing.ts:398:20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants