Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(std/http/server): Respond with 400 on request parse fail… #4593

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

ry
Copy link
Member

@ry ry commented Apr 2, 2020

readRequest should not write a response.

This reverts commit 017a611.

cc @nayeemrmn @kt3k @bartlomieju
ref #4513

…ure (denoland#4551)"

readRequest should not write a response.

This reverts commit 017a611.
@ry ry requested a review from bartlomieju April 2, 2020 19:02
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I shouldn't have merged that PR.

@ry ry merged commit c8fc29f into denoland:master Apr 2, 2020
@ry ry deleted the revert4551 branch April 2, 2020 19:20
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
readRequest should not write a response.

This reverts commit 017a611.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
readRequest should not write a response.

This reverts commit 017a611.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
readRequest should not write a response.

This reverts commit 017a611.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
readRequest should not write a response.

This reverts commit 017a611.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
readRequest should not write a response.

This reverts commit 017a611.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
readRequest should not write a response.

This reverts commit 017a611.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
readRequest should not write a response.

This reverts commit 017a611.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
readRequest should not write a response.

This reverts commit 017a611.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
readRequest should not write a response.

This reverts commit 017a611.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants