Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(std/http/server): Respond with 400 on request parse failure #4551

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

nayeemrmn
Copy link
Collaborator

Correctly brings back the error handling removed in #4435 (comment).

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nayeemrmn

@bartlomieju bartlomieju merged commit 017a611 into denoland:master Apr 1, 2020
@nayeemrmn nayeemrmn deleted the request-error-handling branch April 1, 2020 11:45
nayeemrmn added a commit to nayeemrmn/deno that referenced this pull request Apr 2, 2020
ry added a commit to ry/deno that referenced this pull request Apr 2, 2020
…ure (denoland#4551)"

readRequest should not write a response.

This reverts commit 017a611.
nayeemrmn added a commit to nayeemrmn/deno that referenced this pull request Apr 3, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants