Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#4550): setCookie should append cookies #4558

Merged
merged 1 commit into from
Apr 1, 2020
Merged

fix(#4550): setCookie should append cookies #4558

merged 1 commit into from
Apr 1, 2020

Conversation

zhmushan
Copy link
Contributor

@zhmushan zhmushan commented Apr 1, 2020

No description provided.

@lucacasonato
Copy link
Member

Should this whole thing be renamed to addCokkie if that is what it does now right? Because IMO set should override and add should append.

@zhmushan
Copy link
Contributor Author

zhmushan commented Apr 1, 2020 •
edited
Loading

@lucacasonato I followed the naming of golang

ry
ry approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 5ac2c4a into denoland:master Apr 1, 2020
@zhmushan zhmushan deleted the cookie_append branch April 1, 2020 13:37
@ry ry mentioned this pull request Apr 1, 2020
Closed
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@zhmushan
fix(denoland/deno#4550): setCookie should append cookies (denoland/de…
24c4b71 
…no#4558)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@zhmushan
fix(denoland/deno#4550): setCookie should append cookies (denoland/de…
b3e99b1 
…no#4558)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@zhmushan @caspervonb
fix(denoland/deno#4550): setCookie should append cookies (denoland/de…
d297dc1 
…no#4558)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@zhmushan @caspervonb
fix(denoland/deno#4550): setCookie should append cookies (denoland/de…
6585315 
…no#4558)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@zhmushan @caspervonb
fix(denoland/deno#4550): setCookie should append cookies (denoland/de…
a208957 
…no#4558)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@zhmushan @caspervonb
fix(denoland/deno#4550): setCookie should append cookies (denoland/de…
d1e1331 
…no#4558)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@zhmushan @caspervonb
fix(denoland/deno#4550): setCookie should append cookies (denoland/de…
af2bd39 
…no#4558)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@zhmushan @denobot
fix(denoland/deno#4550): setCookie should append cookies (denoland/de…
2663240 
…no#4558)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@zhmushan @denobot
fix(denoland/deno#4550): setCookie should append cookies (denoland/de…
3159118 
…no#4558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhmushan @lucacasonato @ry