-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setCookie resets other cookies #4550
Labels
bug
Something isn't working correctly
Comments
ry
pushed a commit
that referenced
this issue
Apr 1, 2020
@jakajancar This issue should be closed |
Fixed in #4558 |
👍 thanks @zhmushan |
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this issue
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this issue
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this issue
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this issue
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this issue
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this issue
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this issue
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this issue
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this issue
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
setCookie
instd/http/cookie.ts
will reset other cookies being set (replace the entireSet-Cookie
header). I did not expect this.Perhaps the easiest fix is to change from:
to
Alternatively, perhaps
res.headers.append()
can be used insetCookie
.As it stands now, there is no way to set/modify two cookies in a single response with these utilities (e.g. session id and nonce for OAuth).
The text was updated successfully, but these errors were encountered: