[WIP] [Help needed] Implement Blob get data methods #4396
Conversation
| @@ -124,6 +126,36 @@ function processBlobParts( | |||
| return bytes; | |||
| } | |||
|
|
|||
| function getStream(blobBytes: Uint8Array): ReadableStream { | |||
| return new ReadableStream({ | |||
|
|
|||
There was a problem hiding this comment.
ReadableStream({
start(controller) {
controller.enqueue(blobBytes);
Maybe?
I think these need some tests too. These would be great to have!
There was a problem hiding this comment.
ye added a test for the text() method. i was considering other tests as well, but text() relies on code that appears in the arrayBuffer() method, and that again uses code from the stream() method, so if any of them fail, the test would fail as well + testing those 2 would be a bit of a pain and stupid, as testing arrayBuffer() would literally be the same code as text()
There was a problem hiding this comment.
hayd's suggestion is correct. ReadableStream must be constructed with data sources. In this case, actually data is not stream but just fixed byte array. So it's enough to pass entire bytes to controller (ReadableStreamController). It may be good to slice bytes into chunks if data is too big. But blob is immutable data. controller.enqueue(blobBytes); is enough.
See: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream/ReadableStream
| @@ -124,6 +126,36 @@ function processBlobParts( | |||
| return bytes; | |||
| } | |||
|
|
|||
| function getStream(blobBytes: Uint8Array): ReadableStream { | |||
| return new ReadableStream({ | |||
|
|
|||
There was a problem hiding this comment.
hayd's suggestion is correct. ReadableStream must be constructed with data sources. In this case, actually data is not stream but just fixed byte array. So it's enough to pass entire bytes to controller (ReadableStreamController). It may be good to slice bytes into chunks if data is too big. But blob is immutable data. controller.enqueue(blobBytes); is enough.
See: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream/ReadableStream
| @@ -124,6 +126,36 @@ function processBlobParts( | |||
| return bytes; | |||
| } | |||
|
|
|||
| function getStream(blobBytes: Uint8Array): ReadableStream { | |||
There was a problem hiding this comment.
| function getStream(blobBytes: Uint8Array): ReadableStream { | |
| function getStream(blobBytes: Uint8Array): domTypes.ReadableStream<Uint8Array> { |
You'll get type error because srandarized's stream is incompatible with deno's global type definition, but I think this is better.
183589e
to
16da5c3
Compare
I am trying to implement Blob's
stream,text&arrayBuffermethods, which allow the reading of data from a blob.This would resolve #2303 & resolve #4142, and also allows me to finalize the tests for #4363.
The last thing missing is the implementation of the
get streamalgorithm, for which i need some help.