Implement formdata as body #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etch request body
…etch request body
… implement_formdata_as_body
ry
reviewed
Mar 14, 2020
There was a problem hiding this comment.
Thanks - but I think we should get a basic unit test for this feature. You can look in https://github.com/denoland/deno/blob/master/cli/js/tests/fetch_test.ts for examples of other tests.
|
I created the test, tho, it isnt the best as i wanted to test the ability of files, |
ry
reviewed
Mar 17, 2020
| const resultForm = await response.formData(); | ||
| assertEquals(form.get("field"), resultForm.get("field")); | ||
| } | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #4327
I have not made a unit test for it as i am unsure how the system works with servers