Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use discord instead of gitter #4253

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Use discord instead of gitter #4253

merged 2 commits into from
Mar 5, 2020

Conversation

ry
Copy link
Member

@ry ry commented Mar 4, 2020

No description provided.

@ry ry merged commit 159de02 into denoland:master Mar 5, 2020
@ry ry deleted the discord branch March 5, 2020 00:49
@dstaley
Copy link

dstaley commented Mar 5, 2020

@ry As someone who is in the middle of moving to Gitter, I'd love to hear a bit about what prompted the switch to Discord. Also, did you consider other options?

@ry
Copy link
Member Author

ry commented Mar 5, 2020 •
edited
Loading

It’s buggy and not being updated. No I haven’t really considered other options. Discord was recommended from friends.

@chuckxD
Copy link

chuckxD commented Mar 5, 2020 •
edited
Loading

@ry Discord is great although the learning curve for implementing some of channel configuration, moderation, user permission management can be quite steep depending on how you to administer/interact with contributors and anyone else in between. A good Discord setup can help you min/max the signal-to-noise you might have been getting in Gitter. I'd lean one of your close buds and maybe some pre-existing/larger Discord dev groups to help you maybe bootstrap some good guidelines, channel rules, and moderation settings to create an effective way you want to engage with the rest of the deno community. ♥

@jakeg
Copy link
Contributor

jakeg commented Mar 5, 2020

I could see the old Gitter chat just by clicking a look from the Deno home page without having to log in. Now when I click the link I get told that ry "invited me" to join the chat, and clicking that takes me to download the app from the Android Play store. This is a regression unfortunately. Is it possible to view Discord chats without logging in or downloading an app?

@crowlKats
Copy link
Member

@jakeg no you need to be logged in to use discord. Though if you are on the discord website on desktop and click "Open Discord in your browser" you can interact with discord (and so join servers etc) without doing an actual registration.
The control you have in discord as a server moderator is quite nice to have, especially once you add bots etc, so i think it isnt a regression but progression. There is to remember that discord was intended for gaming, and not for coding (though does have code markdown), so stuff like viewing the chat channels from a website with an embed is not a thing as there would be little to no point. The only embed discord provides is to view the voice channels and who is in them, but nothing more.

@jakeg
Copy link
Contributor

jakeg commented Mar 5, 2020

@crowlKats oh, don't get me wrong, I'm sure there are lots of benefits. I'm just saying that the lack of this particular feature (web based viewing without logging in) is an unfortunate regression. Seeing as that was the only way I was using it before, it's a shame for me, and I'm sure others too.

dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 5, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem2b
45f6569 
* denoland/master:
  Support async function and EventListenerObject as listeners (denoland#4240)
  Allow BadResource errors to take a custom message (denoland#4251)
  Document TypeScript compiler options (denoland#4241)
  refactor: preliminary cleanup of Deno.runTests() (denoland#4237)
  refactor: cleanup compiler runtimes (denoland#4230)
  Use discord instead of gitter (denoland#4253)
  Remove unnecessary macro from cli/ops/tty.rs (denoland#4254)
  Remove Deno.errors.Other (denoland#4249)
  refactor: rewrite testPerm into unitTest (denoland#4231)
  Migrate internal bundles to System (denoland#4233)
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 5, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem2a
cea3d72 
* denoland/master: (22 commits)
  fix event target tests
  Support async function and EventListenerObject as listeners (denoland#4240)
  Allow BadResource errors to take a custom message (denoland#4251)
  Document TypeScript compiler options (denoland#4241)
  refactor: preliminary cleanup of Deno.runTests() (denoland#4237)
  refactor: cleanup compiler runtimes (denoland#4230)
  Use discord instead of gitter (denoland#4253)
  Remove unnecessary macro from cli/ops/tty.rs (denoland#4254)
  Remove Deno.errors.Other (denoland#4249)
  refactor: rewrite testPerm into unitTest (denoland#4231)
  Migrate internal bundles to System (denoland#4233)
  Fix inlining of lib.dom.iterable.d.ts. (denoland#4242)
  Fix `deno install` file name including extra dot on Windows (denoland#4243)
  assert build success for test plugin (denoland#4223)
  Disable flaky and broken tests (denoland#4239)
  add assertOps sanitizer in cli/js/ unit tests (denoland#4209)
  misc: reduce unnecesarry output in cli/js tests (denoland#4182)
  feat(std/node): add directory classes (denoland#4087)
  Do not convert exceptions to JSON and back (denoland#4214)
  Don't reset exception handle after calling ErrWithV8Handle::get_handle() (denoland#4214)
  ...
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 5, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem1c
45c5875 
* denoland/master:
  fix event target tests
  Support async function and EventListenerObject as listeners (denoland#4240)
  Allow BadResource errors to take a custom message (denoland#4251)
  Document TypeScript compiler options (denoland#4241)
  refactor: preliminary cleanup of Deno.runTests() (denoland#4237)
  refactor: cleanup compiler runtimes (denoland#4230)
  Use discord instead of gitter (denoland#4253)
  Remove unnecessary macro from cli/ops/tty.rs (denoland#4254)
  Remove Deno.errors.Other (denoland#4249)
@Picoseconds
Copy link

@jakeg I believe the intention is for people to already use Discord for other purposes, and so be able to view. Discord is not developer oriented, in fact, you must be invited to view messages. This is unfortunately just the style of Discord.

@t3ned
Copy link

t3ned commented May 13, 2020 •
edited
Loading

Created a discord server for Deno's community: https://discord.gg/hJMjY7J

@lucacasonato
Copy link
Member

Deno already has a discord server: https://discord.gg/deno :-)

@t3ned
Copy link

t3ned commented May 13, 2020

Deno already has a discord server: https://discord.gg/deno :-)

Damn checked earlier and couldn't find one

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@ry
Use discord instead of gitter (denoland/deno#4253)
b8a67c3
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@ry
Use discord instead of gitter (denoland/deno#4253)
460131e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@ry @caspervonb
Use discord instead of gitter (denoland/deno#4253)
3ba7319
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@ry @caspervonb
Use discord instead of gitter (denoland/deno#4253)
ab2a50a
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ry @caspervonb
Use discord instead of gitter (denoland/deno#4253)
ea95a00
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ry @caspervonb
Use discord instead of gitter (denoland/deno#4253)
62a7b9a
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ry @caspervonb
Use discord instead of gitter (denoland/deno#4253)
9c1717c
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ry @denobot
Use discord instead of gitter (denoland/deno#4253)
41de777
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@ry @denobot
Use discord instead of gitter (denoland/deno#4253)
049abfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ry @dstaley @chuckxD @jakeg @crowlKats @Picoseconds @t3ned @lucacasonato @piscisaureus