Assert success on build_test_plugin #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ry (tagging for review) |
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 5, 2020
* denoland/master: (22 commits) fix event target tests Support async function and EventListenerObject as listeners (denoland#4240) Allow BadResource errors to take a custom message (denoland#4251) Document TypeScript compiler options (denoland#4241) refactor: preliminary cleanup of Deno.runTests() (denoland#4237) refactor: cleanup compiler runtimes (denoland#4230) Use discord instead of gitter (denoland#4253) Remove unnecessary macro from cli/ops/tty.rs (denoland#4254) Remove Deno.errors.Other (denoland#4249) refactor: rewrite testPerm into unitTest (denoland#4231) Migrate internal bundles to System (denoland#4233) Fix inlining of lib.dom.iterable.d.ts. (denoland#4242) Fix `deno install` file name including extra dot on Windows (denoland#4243) assert build success for test plugin (denoland#4223) Disable flaky and broken tests (denoland#4239) add assertOps sanitizer in cli/js/ unit tests (denoland#4209) misc: reduce unnecesarry output in cli/js tests (denoland#4182) feat(std/node): add directory classes (denoland#4087) Do not convert exceptions to JSON and back (denoland#4214) Don't reset exception handle after calling ErrWithV8Handle::get_handle() (denoland#4214) ...
mhvsa
pushed a commit
to mhvsa/deno
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ubuntu-test-debugcheck will fail on the basic test located ontest_plugin/tests/integration_tests.rsif the build_pluginCommandisn't successful. This command is silent so there is no information that this was the cause.Example: If a change is made somewhere that causes the build_plugin
Commandto fail, but there was a successful build in the past, thencargo test basicwill be successful on local but it will fail on the CIubuntu-test-debugcheck.This PR ensures that the build must be successful.