Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove channel parameter from deno.send/recv #341

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Remove channel parameter from deno.send/recv #341

merged 1 commit into from
Jul 6, 2018

Conversation

ry
Copy link
Member

@ry ry commented Jul 6, 2018 •
edited

depends on #334

@ry ry requested a review from piscisaureus July 6, 2018 20:35
@ry ry changed the base branch from master to deno_cc_load July 6, 2018 20:37
@ry ry changed the base branch from deno_cc_load to master July 6, 2018 21:39
piscisaureus
piscisaureus approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - LGTM too!

@ry ry merged commit a2dde56 into master Jul 6, 2018
@ry ry deleted the remove_channel branch July 6, 2018 22:25
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Oct 7, 2019
@axetroy @ry
fs utils getFileInfoType() return undefined when not found (denoland#341
0a61800 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @piscisaureus