More flatbuffers work in TS/C++. Demonstrate linking rust lib into deno_cc. #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
force-pushed
the
deno_cc_load
branch
3 times, most recently
from
eb548a8
to
fd124fe
Compare
ry
force-pushed
the
deno_cc_load
branch
2 times, most recently
from
83a9c96
to
1207f52
Compare
ry
changed the title
|
@piscisaureus PTAL |
ry
changed the title
- Port protobuf messages to flatbuffers. - Demo linking to rust from C++ executable. - Start using the prototype TS libraries.
ry
commented
Jul 6, 2018
| @@ -8,6 +8,9 @@ import("//build_extra/rust/rust.gni") | |||
| config("deno_config") { | |||
| include_dirs = [ "third_party/v8" ] # This allows us to v8/src/base/ libraries. | |||
| configs = [ "third_party/v8:external_config" ] | |||
| if (is_debug) { | |||
| defines = [ "DEBUG" ] | |||
| } | |||
There was a problem hiding this comment.
Surprising that DEBUG wasn't already set...
piscisaureus
approved these changes
Jul 6, 2018
| @@ -8,6 +8,9 @@ import("//build_extra/rust/rust.gni") | |||
| config("deno_config") { | |||
| include_dirs = [ "third_party/v8" ] # This allows us to v8/src/base/ libraries. | |||
| configs = [ "third_party/v8:external_config" ] | |||
| if (is_debug) { | |||
| defines = [ "DEBUG" ] | |||
| } | |||
There was a problem hiding this comment.
Surprising that DEBUG wasn't already set...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #337