Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"node:process" is broken in "@azure/identity" since v1.43.6 #24233

Closed
bartlomieju opened this issue Jun 17, 2024 · 0 comments · Fixed by #24240
Closed

"node:process" is broken in "@azure/identity" since v1.43.6 #24233

bartlomieju opened this issue Jun 17, 2024 · 0 comments · Fixed by #24240
Labels
bug Something isn't working correctly node compat

Comments

@bartlomieju
Copy link
Member

import { ClientSecretCredential } from "npm:@azure/identity";
const test = new ClientSecretCredential("a","b","c",);
console.log(test);
$ deno --version
v1.43.5
$ deno run foo.js
ClientSecretCredential {
  clientSecret: "c",
  tenantId: "a",
  additionallyAllowedTenantIds: [],
  msalClient: {
    getTokenByClientSecret: [AsyncFunction: getTokenByClientSecret],
    getTokenByClientAssertion: [AsyncFunction: getTokenByClientAssertion],
    getTokenByClientCertificate: [AsyncFunction: getTokenByClientCertificate]
  }
}
$ deno --version
v1.43.6
$ deno run foo.js
error: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'bun')
    at setPlatformSpecificData (file:https:///Users/ib/dev/deno/node_modules/.deno/@[email protected]/node_modules/@azure/core-rest-pipeline/dist/commonjs/util/userAgentPlatform.js:23:18)
    at getUserAgentValue (file:https:///Users/ib/dev/deno/node_modules/.deno/@[email protected]/node_modules/@azure/core-rest-pipeline/dist/commonjs/util/userAgent.js:29:56)
    at userAgentPolicy (file:https:///Users/ib/dev/deno/node_modules/.deno/@[email protected]/node_modules/@azure/core-rest-pipeline/dist/commonjs/policies/userAgentPolicy.js:18:65)
    at createPipelineFromOptions (file:https:///Users/ib/dev/deno/node_modules/.deno/@[email protected]/node_modules/@azure/core-rest-pipeline/dist/commonjs/createPipelineFromOptions.js:34:65)
    at createClientPipeline (file:https:///Users/ib/dev/deno/node_modules/.deno/@[email protected]/node_modules/@azure/core-client/dist/commonjs/pipeline.js:16:73)
    at createDefaultPipeline (file:https:///Users/ib/dev/deno/node_modules/.deno/@[email protected]/node_modules/@azure/core-client/dist/commonjs/serviceClient.js:136:51)
    at new ServiceClient (file:https:///Users/ib/dev/deno/node_modules/.deno/@[email protected]/node_modules/@azure/core-client/dist/commonjs/serviceClient.js:32:45)
    at new IdentityClient (file:https:///Users/ib/dev/deno/node_modules/.deno/@[email protected]/node_modules/@azure/identity/dist/index.js:586:9)
    at generateMsalConfiguration (file:https:///Users/ib/dev/deno/node_modules/.deno/@[email protected]/node_modules/@azure/identity/dist/index.js:1946:24)
    at createMsalClient (file:https:///Users/ib/dev/deno/node_modules/.deno/@[email protected]/node_modules/@azure/identity/dist/index.js:1976:21)

Another repro:

import process from "node:process";
Object.prototype.hasOwnProperty.call(process, "versions");
$ deno --version
v1.43.5
$ deno run foo.js
true
$ deno --version
v1.43.6
$ deno run foo.js
false

This is caused by #23865.

Ref #24061 (comment)

CC @marvinhagemeister @reeceorbuck @tesharp

@bartlomieju bartlomieju added bug Something isn't working correctly node compat labels Jun 17, 2024
littledivy added a commit to littledivy/deno that referenced this issue Jun 18, 2024
Fixes denoland#24233

This is a quick fix. There are some more properties that should be on
the object rather than the class, this'll do for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly node compat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant