fix(ext/node): better support for node:diagnostics_channel module
#24088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Jun 3, 2024
devsnek
approved these changes
Jun 14, 2024
| nextTick(() => { | ||
| // TODO(bartlomieju): in Node.js this is using `triggerUncaughtException` API, need | ||
| // to clarify if we need that or if just throwing the error is enough here. | ||
| throw err; |
There was a problem hiding this comment.
i think window.reportError is mostly the equiv in deno? though i guess maybe this throw ends up there anyway?
There was a problem hiding this comment.
Ah, good point. Let me see if changing that allows to enable more tests
There was a problem hiding this comment.
Yeah, I believe it ends up there anyway. I'm gonna leave this TODO for now
bartlomieju
added a commit
that referenced
this pull request
Jun 18, 2024
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24060