Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node:diagnostic_channel misses DiagnosticChannel::tracingChannel API #24060

Closed
Tracked by #23744
bartlomieju opened this issue May 31, 2024 · 0 comments · Fixed by #24088
Closed
Tracked by #23744

node:diagnostic_channel misses DiagnosticChannel::tracingChannel API #24060

bartlomieju opened this issue May 31, 2024 · 0 comments · Fixed by #24088
Assignees
@bartlomieju
Labels
bug Something isn't working correctly node API polyfill Related to various "node:*" modules APIs node compat

Comments

@bartlomieju
Copy link
Member

bartlomieju commented May 31, 2024 •
edited

Required for dd-trace

error: Uncaught TypeError: dc.tracingChannel is not a function
    at Object.<anonymous> (file:https:///Users/sr/p/trace-examples/javascript/node/microservices/user/node_modules/dd-trace/packages/dd-trace/src/appsec/channels.js:10:32)
    at Object.<anonymous> (file:https:///Users/sr/p/trace-examples/javascript/node/microservices/user/node_modules/dd-trace/packages/dd-trace/src/appsec/channels.js:23:4)
    at Module._compile (node:module:659:34)
    at Object.Module._extensions..js (node:module:673:10)
    at Module.load (node:module:597:32)
    at Function.Module._load (node:module:484:12)
    at Module.require (node:module:609:19)
    at Module.Hook.Module.require (file:https:///Users/sr/p/trace-examples/javascript/node/microservices/user/node_modules/dd-trace/packages/dd-trace/src/ritm.js:85:33)
    at require (node:module:715:16)
    at Object.<anonymous> (file:https:///Users/sr/p/trace-examples/javascript/node/microservices/user/node_modules/dd-trace/packages/datadog-plugin-http/src/server.js:6:62)

API: https://nodejs.org/api/diagnostics_channel.html#class-tracingchannel

#23744
@bartlomieju bartlomieju added bug Something isn't working correctly node compat node API polyfill Related to various "node:*" modules APIs labels May 31, 2024
@bartlomieju bartlomieju self-assigned this May 31, 2024
@bartlomieju bartlomieju mentioned this issue Jun 3, 2024
Merged
@satyarohith satyarohith mentioned this issue Jun 11, 2024
Open
3 tasks
bartlomieju added a commit that referenced this issue Jun 18, 2024
@bartlomieju
fix(ext/node): better support for node:diagnostics_channel module (#…
3308964 
…24088)

Closes #24060
zebreus pushed a commit to zebreus/deno that referenced this issue Jul 8, 2024
@bartlomieju @zebreus
fix(ext/node): better support for node:diagnostics_channel module (d…
a15c0af 
…enoland#24088)

Closes denoland#24060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlomieju bartlomieju

Labels
bug Something isn't working correctly node API polyfill Related to various "node:*" modules APIs node compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ext/node): better support for node:diagnostics_channel module bartlomieju/deno
1 participant
@bartlomieju